feat(region): added regions and fix issues#4
Merged
Merged
Conversation
crsstha
requested review from
AdityaKhatri,
AmritBhusal,
shreeyash07 and
subinasr
shreeyash07
requested changes
Jun 17, 2026
Comment on lines
47
to
48
| filters: { thematicAreaId: $thematicAreaId, reportType: $reportType, regions: $regions } | ||
| pagination: { limit: $limit, offset: $offset } |
Contributor
There was a problem hiding this comment.
you can directly assign type here.
Comment on lines
33
to
34
| filters: { page: $page, isActive: $isActive , regions: $regions} | ||
| pagination: { limit: $limit, offset: $offset } |
Contributor
There was a problem hiding this comment.
same here you can assign filters and pagination type directly
shreeyash07
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any
console.logmeant for debuggingThis PR includes