fix(optimizer): prevent pruning columns referenced by GROUP BY / HAVING / QUALIFY - #8121
Open
fivetran-kwoodbeck wants to merge 3 commits into
Open
fix(optimizer): prevent pruning columns referenced by GROUP BY / HAVING / QUALIFY#8121fivetran-kwoodbeck wants to merge 3 commits into
fivetran-kwoodbeck wants to merge 3 commits into
Conversation
Contributor
SQLGlot Integration Test Results✅ All tests passedComparing:
Overallmain: 182937 total, 160861 passed (pass rate: 87.9%) sqlglot:optimizer/fix-pushdown-prunes-shadowed-clause-columns: 170743 total, 149709 passed (pass rate: 87.7%) Transitions: Dialect pair changes: 0 previous results not found, 3 current results not found ✅ All tests passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pushdown_projectionsdecides which projections to keep by scanningColumnnodes and grouping them by source table. For BigQuery (PROJECTION_ALIASES_SHADOW_SOURCE_NAMES), the alias-shadow workaround rewritesGROUP BY/HAVING/QUALIFYreferences into bareIdentifiers when a projection alias collides with a source name, and its earlyreturncan also leave later references as unqualifiedColumns. Both forms were invisible to the scan, so the columns they reference were pruned from the inner scope, producing invalid SQL.Sample Input
Previous Output (invalid:
ais pruned but still referenced byGROUP BY/HAVING)Expected Output
The fix scans the
GROUP BY/HAVING/QUALIFYclauses for bareIdentifiers and unqualifiedColumns, resolves them withResolver, and adds them to the kept-column set.