Add stack reconstruction methods for inlined contexts and wrap reconstruction points in SPC#595
Open
matthew-mojira wants to merge 14 commits intotitzer:masterfrom
Open
Add stack reconstruction methods for inlined contexts and wrap reconstruction points in SPC#595matthew-mojira wants to merge 14 commits intotitzer:masterfrom
matthew-mojira wants to merge 14 commits intotitzer:masterfrom
Conversation
Contributor
Author
|
I had "fun" using lambdas to make |
matthew-mojira
changed the title
titzer
reviewed
Mar 25, 2026
| // Save mem0 base | ||
| masm.emit_mov_m_r(ValueKind.REF, frame.mem0_base_slot, mem_reg); | ||
|
|
||
| // use same vfp for all frames |
Owner
There was a problem hiding this comment.
This is probably not right; you probably need to compute the right VFP for each frame as some delta from the current VFP.
Contributor
Author
|
Sneaking in another change in 9bf2aeb to actually increment the metrics added in this PR. |
titzer
reviewed
Mar 29, 2026
Contributor
Author
|
I separated reconstruction of a single frame in 7b8ae6d but it seems a little cumbersome to pass around pre-allocated registers and offsets like that. Is this what you had in mind? |
titzer
reviewed
Mar 31, 2026
|
|
||
| // get functions[func_index] and save into frame | ||
| def wasm_func_slot = frame.wasm_func_slot.plus(frame_offset); | ||
| masm.emit_v3_Array_elem_r_ri(ValueKind.REF, wasm_func_reg, func_reg, spcFrame.func.func_index); |
Owner
There was a problem hiding this comment.
I think this should be inst_reg instead of func_reg
Contributor
Author
There was a problem hiding this comment.
I don't think it should. This is indexing into the array instance.functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit contains:
SinglePassCompiler.emitReconstructStackFrameswhich is the general purpose stack reconstruction method. It is called fromwithReconstructedInlinedFrameswhich wraps stack reconstruction (only needed if in an inlined context) around a piece of compiler code.X86_64SpcModuleCode.reconstructInlinedFramesForTrapwhich reconstructs stack frames by bumpingrspand insertingfidandpcin the case of a hardware trap (which bypasses the usual stack reconstruction point for traps).withReconstructedInlinedFrames