Skip to content

fix(platform): validate Copilot and Antigravity ports#658

Draft
tirth8205 wants to merge 4 commits into
mainfrom
codex/reconcile-copilot-antigravity
Draft

fix(platform): validate Copilot and Antigravity ports#658
tirth8205 wants to merge 4 commits into
mainfrom
codex/reconcile-copilot-antigravity

Conversation

@tirth8205

@tirth8205 tirth8205 commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Latest refresh — 18 July 2026

  • rebased onto main 0a3bd6c; current head 5496791
  • fixed all-platform test isolation so tests do not touch the real user home
  • all 15 hosted checks passed on the current head
  • released VS Code and GitHub Copilot CLI validation passed; only Antigravity remains

Status

Draft — do not merge until the released Antigravity checks below pass.

This completes the focused maintainer ports promised when source PRs #129 and #531 were closed. Contributor attribution is preserved.

Change

  • detect the actual GitHub Copilot VS Code extension instead of any VS Code installation
  • detect the Copilot extension bundled inside released VS Code builds
  • write the released Copilot CLI mcpServers contract with type: local and tools: ["*"]
  • install Antigravity workspace skills only at .agents/skills/<skill>/SKILL.md; do not carry the source PR's obsolete hooks
  • preserve unrelated servers and skills on install/reinstall
  • remove only generated code-review-graph entries and Antigravity skills on uninstall

Automated validation

  • source contract regressions: 3 failed before, then passed after the port
  • Antigravity uninstall regression: failed before, then passed after the fix
  • focused install/skills/uninstall suite: 224 passed
  • complete non-daemon suite: 1,967 passed, 1 skipped, 2 expected deselections, 2 xpassed
  • both multiprocessing parity checks: 2 passed
  • independent maintainer critical-path check: 7 passed
  • Ruff and git diff --check: clean
  • current GitHub head: 15/15 checks passed

Real-client result

PASSED — GitHub Copilot:

  • released VS Code 1.127.0 with bundled GitHub.copilot-chat 0.55.0 was detected
  • VS Code resolved the generated workspace .vscode/mcp.json without a configuration parse error
  • official GitHub Copilot CLI 1.0.71 loaded ~/.copilot/mcp-config.json from the user source
  • Copilot CLI connected to the code-review-graph MCP server and successfully called list_graph_stats_tool; the real result returned total_nodes: 4334
  • reinstall left both seeded Copilot config files byte-for-byte unchanged and preserved their unrelated servers/settings
  • uninstall reported zero errors, removed only code-review-graph from both configs, and preserved the unrelated servers/settings
  • released VS Code reopened the remaining post-uninstall config and registered the unrelated MCP server; no code-review-graph server remained
  • the disposable VS Code instance was closed after validation

Required real-client validation

Do not mark this ready or merge it until all items below are recorded with released clients.

GitHub Copilot

  • released VS Code with the actual GitHub Copilot extension triggers the intended auto-detection and loads the generated workspace MCP server without configuration errors
  • released GitHub Copilot CLI loads ~/.copilot/mcp-config.json and invokes a code-review-graph tool successfully
  • reinstall preserves unrelated Copilot MCP entries
  • uninstall removes only code-review-graph and both clients still load their remaining configuration

Google Antigravity

  • the released Antigravity app opens the workspace and discovers a generated .agents skill
  • Antigravity uses a generated skill and invokes a code-review-graph MCP tool successfully
  • reinstall preserves an unrelated workspace skill
  • uninstall removes only generated code-review-graph skills and Antigravity still loads the remaining workspace

Carries PR #129 with npkriami18 credited and PR #531 with 0deep credited.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

code-review-graph review

Overall risk: 0.80 (HIGH) — 25 changed function(s)/class(es), 0 affected flow(s), 14 test gap(s)

Risk-scored changes

Risk Level Symbol Location Tested
0.80 high code_review_graph/cli.py::_handle_init code_review_graph/cli.py:197 no
0.40 medium code_review_graph/skills.py::install_antigravity_skills code_review_graph/skills.py:1418 no
0.40 medium tests/test_skills.py::TestInstallSkillsRespectTargetPlatform._run_install tests/test_skills.py:2236 no
0.35 low code_review_graph/skills.py::_copilot_vscode_detected code_review_graph/skills.py:35 no
0.35 low code_review_graph/skills.py::_build_server_entry code_review_graph/skills.py:337 no
0.35 low code_review_graph/uninstall.py::_process_repo code_review_graph/uninstall.py:988 no
0.30 low tests/test_cli_install.py::_install_gemini_cli_skills tests/test_cli_install.py:125 no
0.30 low tests/test_cli_install.py::_install_antigravity_skills tests/test_cli_install.py:129 no
0.30 low tests/test_skills.py::TestCopilotPlatform._which tests/test_skills.py:1706 no
0.30 low tests/test_skills.py::TestCopilotCLIPlatform.test_copilot_cli_platform_entry_exists tests/test_skills.py:1734 (test)

Test gaps

  • code_review_graph/cli.py::_handle_init (code_review_graph/cli.py:197)
  • code_review_graph/skills.py::_copilot_vscode_detected (code_review_graph/skills.py:35)
  • code_review_graph/skills.py::_build_server_entry (code_review_graph/skills.py:337)
  • code_review_graph/skills.py::install_antigravity_skills (code_review_graph/skills.py:1418)
  • code_review_graph/uninstall.py::_process_repo (code_review_graph/uninstall.py:988)
  • ...and 9 more without direct tests

Token savings: this graph-backed report used ~91,518 fewer tokens (~95%) than reading every changed file in full (estimated, chars/4 approximation).


Powered by code-review-graph — local-first analysis; no code leaves the CI runner.

tirth8205 and others added 3 commits July 18, 2026 00:31
Use the current GitHub Copilot CLI MCP schema, detect the actual VS Code Copilot extension, and install current workspace-scoped Antigravity skills without importing the stale hook format.

Co-authored-by: npkriami18 <pranaynannuri@gmail.com>

Co-authored-by: 0deep <227102371+0deep@users.noreply.github.com>
@tirth8205
tirth8205 force-pushed the codex/reconcile-copilot-antigravity branch from 28241bb to c5a7815 Compare July 17, 2026 23:38
@tirth8205

Copy link
Copy Markdown
Owner Author

Real-client validation found a blocking Copilot detection gap; this checklist item is FAILED, not passed.

  • Released VS Code 1.127.0 bundles GitHub Copilot as GitHub.copilot-chat 0.55.0 under the application extension directory.
  • The current _copilot_vscode_detected() only scans ~/.vscode/extensions and ~/.vscode-insiders/extensions for github.copilot-*, so a clean released VS Code install is not detected.
  • Installing the marketplace package is not a valid workaround: the released client rejected it because it attempted to downgrade the built-in Copilot Chat 0.55.0 to 0.48.1.

Keep this PR in draft. Detection must recognize the released bundled extension, then VS Code must be reopened against the generated workspace MCP configuration and retested. No merge until that passes.

@tirth8205

Copy link
Copy Markdown
Owner Author

Follow-up: the bundled-Copilot detection blocker from the previous comment is fixed in commit 5496791.

  • The new regression failed before the fix and passed after it.
  • Released VS Code 1.127.0 with bundled GitHub.copilot-chat 0.55.0 is now detected.
  • Auto-install generated .vscode/mcp.json in a disposable workspace.
  • The released app resolved that file and emitted MCP tools/resources/servers changed events without a configuration parse error.
  • All 15 hosted checks passed on 5496791.

The VS Code checklist item is complete. Copilot CLI invocation, reinstall/uninstall, and all Antigravity items are still unverified. This PR remains draft and must not be merged yet.

@tirth8205

Copy link
Copy Markdown
Owner Author

Released-client evidence for head 54967913c646eb8dc2af5caeab3d91aad2d82985:

  • Installed the official GitHub Copilot CLI 1.0.71 into a disposable prefix; the official installer validated the downloaded checksum.
  • copilot mcp get code-review-graph loaded the generated entry from ~/.copilot/mcp-config.json as Source: User, Type: local, with Tools: * (all).
  • A live non-interactive Copilot session connected to the code-review-graph MCP server and called list_graph_stats_tool successfully. The tool returned status: ok, total_nodes: 4334, and total_edges: 34028. The session made no file changes.
  • Both Copilot CLI and VS Code configs were seeded with unrelated settings and servers. Reinstall reported already configured; each file's SHA-256 was unchanged.
  • Surgical uninstall completed with zero errors. It removed only the code-review-graph entry from each config and retained the unrelated settings/servers.
  • After uninstall, Copilot CLI still loaded existing-server from Source: User. Released VS Code 1.127.0 reopened the workspace, initialized its MCP gateway, and created the MCP log channel for only the remaining existing-vscode-server entry. The disposable VS Code process was then closed.
  • Fresh GitHub API verification: 15/15 checks passed on this head; none are pending or failed.

All GitHub Copilot gates are now satisfied. This remains a draft and must not merge until the four released Google Antigravity checks pass.

@rajpratham1 rajpratham1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request provides a well-scoped improvement to platform integration by strengthening GitHub Copilot detection, aligning GitHub Copilot CLI with the documented mcpServers configuration schema, and adding support for Antigravity workspace-scoped skills. The implementation updates the installation and uninstallation workflows, improves configuration accuracy, documents the new behavior, and includes comprehensive test coverage for the added functionality. The changes are consistent across the implementation, documentation, and tests, and no blocking issues were identified during review. LGTM and approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants