Skip to content

WIP: redesign blocks GC #5463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
niaow wants to merge 1 commit into
base: dev
Choose a base branch
from
+1,344 −436
Draft

WIP: redesign blocks GC #5463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions builder/sizes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ func TestBinarySize(t *testing.T) {
// This is a small number of very diverse targets that we want to test.
tests := []sizeTest{
// microcontrollers
{"hifive1b", "examples/echo", 3817, 299, 0, 2252},
{"microbit", "examples/serial", 2820, 356, 8, 2248},
{"wioterminal", "examples/pininterrupt", 8020, 1652, 132, 7480},
{"hifive1b", "examples/echo", 3925, 299, 0, 2260},
{"microbit", "examples/serial", 2876, 356, 8, 2256},
{"wioterminal", "examples/pininterrupt", 8108, 1652, 132, 7488},

// TODO: also check wasm. Right now this is difficult, because
// wasm binaries are run through wasm-opt and therefore the
Expand Down
5 changes: 5 additions & 0 deletions compiler/asserts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,11 @@ func (b *builder) createChanBoundsCheck(elementSize uint64, bufSize llvm.Value,
// It has no effect in well-behaved programs, but makes sure no uncaught nil
// pointer dereferences exist in valid Go code.
func (b *builder) createNilCheck(inst ssa.Value, ptr llvm.Value, blockPrefix string) {
if b.info.nobounds {
// Function disabled bounds checking - skip nil check.
return
}

// Check whether we need to emit this check at all.
if !ptr.IsAGlobalValue().IsNil() {
return
Expand Down
Loading
Loading