Skip to content

fix: value update sql #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IKKEM-Lin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: value update sql #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,15 @@ describe('sqlite-level', () => {
expect(await result.next()).toEqual('value2')
expect(await result.next()).toBeUndefined()
})

it('value update', async () => {
await level.put('fixed_key1', 'value1')
await level.batch([
{type: 'put', key: 'fixed_key1', value: 'value2'},
{type: 'put', key: 'fixed_key2', value: 'value3'},
{type: 'put', key: 'fixed_key2', value: 'value4'},
])
expect(await level.get('fixed_key1')).toEqual('value2')
expect(await level.get('fixed_key2')).toEqual('value4')
})
})
8 changes: 4 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ export class SqliteLevel<KDefault = string, VDefault = string> extends AbstractL
}

async _open(options: AbstractOpenOptions, callback: (error?: Error) => void) {
this.db.exec('CREATE TABLE IF NOT EXISTS kv (key TEXT, value TEXT)')
this.db.exec('CREATE TABLE IF NOT EXISTS kv (key TEXT UNIQUE, value TEXT)')
this.nextTick(callback)
}

Expand Down Expand Up @@ -240,7 +240,7 @@ export class SqliteLevel<KDefault = string, VDefault = string> extends AbstractL
})
)
}
const stmt = this.db.prepare('INSERT INTO kv (key, value) VALUES (?, ?)')
const stmt = this.db.prepare('INSERT INTO kv (key, value) VALUES (?, ?) ON CONFLICT(key) DO UPDATE SET value=excluded.value')
stmt.run(key.toString(), value.toString())
this.nextTick(callback)
}
Expand Down Expand Up @@ -277,7 +277,7 @@ export class SqliteLevel<KDefault = string, VDefault = string> extends AbstractL
curType = op.type
} else if (curType !== op.type) {
if (curType === 'put') {
batches.push(`INSERT INTO kv (key, value) VALUES ${curBatch.join(',')}`)
batches.push(`INSERT INTO kv (key, value) VALUES ${curBatch.join(',')} ON CONFLICT(key) DO UPDATE SET value=excluded.value`)
} else if (curType === 'del') {
batches.push(`DELETE FROM kv WHERE key IN (${curBatch.join(',')})`)
}
Expand All @@ -292,7 +292,7 @@ export class SqliteLevel<KDefault = string, VDefault = string> extends AbstractL
}
if (curBatch.length > 0) {
if (curType === 'put') {
batches.push(`INSERT INTO kv (key, value) VALUES ${curBatch.join(',')}`)
batches.push(`INSERT INTO kv (key, value) VALUES ${curBatch.join(',')} ON CONFLICT(key) DO UPDATE SET value=excluded.value`)
} else if (curType === 'del') {
batches.push(`DELETE FROM kv WHERE key IN (${curBatch.join(',')})`)
}
Expand Down