Initial gateware code for VGA capture#215
Closed
rohitk-singh wants to merge 5 commits intotimvideos:masterfrom
Closed
Initial gateware code for VGA capture#215rohitk-singh wants to merge 5 commits intotimvideos:masterfrom
rohitk-singh wants to merge 5 commits intotimvideos:masterfrom
Conversation
|
|
||
|
|
||
| def do_simulation(self, selfp): | ||
| print ("cycle: {cycle} , hsync: {hsync}, vsync: {vsync}, de: {de}, r: {r}, g: {g}, b: {b}".format( |
Member
There was a problem hiding this comment.
Can you please fix the wrapping here.
Something like;
print("cycle: {cycle} , hsync: {hsync}, vsync: {vsync}, de: {de}, r: {r}, g: {g}, b: {b}".format(
cycle = selfp.simulator.cycle_counter,
hsync = selfp.hsync,
vsync = selfp.vsync,
de = selfp.de,
r = selfp.r,
g = selfp.g,
b = selfp.b,
))
Member
|
Hi @rohit91, Generally things are looking pretty good but there are some small formatting issues. Can you please do the following things;
|
Member
|
@enjoy-digital Can you take a close look at the migen code? |
Member
| * www.analog.com/media/en/technical-documentation/data-sheets/AD9984A.pdf | ||
| * | ||
| * Code below is for AD9984A based VGA capturing for HDMI2USB using VGA | ||
| * Expansion Board for Atlys(https://github.com/timvideos/HDMI2USB-vmodvga) |
c4f26ad to
3a94104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
gateware/vgaatlys_vga.pytarget for vga capturead9984a.candvga_in.cDoesn't have to merged compulsorily. If any suggestions or refactoring/restructuring ideas are there, they are welcome. Any comments also welcome.
Have to add rest of the firmware code for capture to work. There are some conflicts with the code, so haven't committed them yet. Looking into them right now