Skip to content

Initial gateware code for VGA capture#215

Closed
rohitk-singh wants to merge 5 commits intotimvideos:masterfrom
rohitk-singh:master
Closed

Initial gateware code for VGA capture#215
rohitk-singh wants to merge 5 commits intotimvideos:masterfrom
rohitk-singh:master

Conversation

@rohitk-singh
Copy link
Copy Markdown
Contributor

Changes:

  • Added gateware code for vga capture in gateware/vga
  • Added atlys_vga.py target for vga capture
  • Modified atlys platform file with vga pins
  • Added some firmware code for vga capure in ad9984a.c and vga_in.c

Doesn't have to merged compulsorily. If any suggestions or refactoring/restructuring ideas are there, they are welcome. Any comments also welcome.

Have to add rest of the firmware code for capture to work. There are some conflicts with the code, so haven't committed them yet. Looking into them right now

@mithro mithro changed the title Add initial code for VGA capture capibility Add initial code for VGA capture capability Mar 6, 2016
Comment thread gateware/vga/testcapture.py Outdated


def do_simulation(self, selfp):
print ("cycle: {cycle} , hsync: {hsync}, vsync: {vsync}, de: {de}, r: {r}, g: {g}, b: {b}".format(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the wrapping here.

Something like;

    print("cycle: {cycle} , hsync: {hsync}, vsync: {vsync}, de: {de}, r: {r}, g: {g}, b: {b}".format(
        cycle = selfp.simulator.cycle_counter,
        hsync = selfp.hsync,
        vsync = selfp.vsync,
        de = selfp.de,
        r = selfp.r,
        g = selfp.g,
        b = selfp.b,
        ))

@mithro
Copy link
Copy Markdown
Member

mithro commented Mar 6, 2016

Hi @rohit91,

Generally things are looking pretty good but there are some small formatting issues. Can you please do the following things;

  • Run the python code through pep8. Due to the way migen code is generally formatted, you won't be able to be 100% pep8 clean, but it should at least show you where you have some formatting problems.
  • Fix tabs/spaces in the C code. It seems most of the existing code uses tabs.

@mithro
Copy link
Copy Markdown
Member

mithro commented Mar 6, 2016

@enjoy-digital Can you take a close look at the migen code?

@mithro
Copy link
Copy Markdown
Member

mithro commented Mar 24, 2016

@rohit91 Was this the code that @CarlFK got working today?

Comment thread firmware/lm32/ad9984a.c Outdated
* www.analog.com/media/en/technical-documentation/data-sheets/AD9984A.pdf
*
* Code below is for AD9984A based VGA capturing for HDMI2USB using VGA
* Expansion Board for Atlys(https://github.com/timvideos/HDMI2USB-vmodvga)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space between Atlys and (

@rohitk-singh rohitk-singh force-pushed the master branch 2 times, most recently from c4f26ad to 3a94104 Compare August 6, 2016 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants