More plotting updates#123
Merged
Merged
Conversation
- add helper method to conver window to xy arrays - add generic contour_array and vcontour_array methods to gather contouring logic in one function - add quiver_xy and quiver_z plotting methods for plotting quivers of velocity fields.
- Add stream_function method to steady model class - add velocity_grid method
…, and deprecate legacy functions - use contour_array behind the scenes for head contour plot - make headalongline similar to transient headalongline plot - ensure return_contours is available everywhere - support cmap argument in contour functions - rename vcontoursf1d to vcontour_stream_function - more support for kwargs - add quiver_xy and quiver_z methods
- align head_along_line between steady and transient implementations - support colormaps in contour functions - use contour_array functions behind the scenes - ensure return_contours are returned everywhere - add quiver_xy and quiver_z plot methods
- improve docstrings, indicate arrays are 1d - use tqdm_check everywhere - convert x,y,z,and t to 1d arrays
mbakker7
approved these changes
Jun 2, 2026
Contributor
mbakker7
left a comment
mbakker7
left a comment
There was a problem hiding this comment.
Nice additions and improvements.
Are these included in some of the notebooks in the docs?
Contributor
Author
Not yet, if we come across any spots where it might be nice to showcase them that would be a good idea so that the methods are actually sort of tested :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alright, more work unifying the plotting between steady and transient.