feat(config): enable read-only mode by default for new installations#164
Open
aprimakina wants to merge 1 commit into
Open
feat(config): enable read-only mode by default for new installations#164aprimakina wants to merge 1 commit into
aprimakina wants to merge 1 commit into
Conversation
Flip the read_only default to true so fresh installs refuse mutating operations (CLI service commands, MCP write tools) and open database sessions read-only until the user opts in with `tiger config set read_only false`. Existing installations are grandfathered: older CLI versions only wrote read_only to the config file when set explicitly, so a config file without the key predates the default flip and MigrateReadOnly (same in-memory-shim pattern as MigrateVersionCheck) resolves it to false. To keep that detection sound, every config file written by Set/Unset/Reset now records read_only explicitly; unsetting or resetting restores the current default (true). The integration test suite sets TIGER_READ_ONLY=false since it exercises real mutating commands, and ErrReadOnly now tells users how to disable read-only mode. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
aprimakina
force-pushed
the
read-only-default-for-new-installs
branch
from
96c09f0 to
7c04e4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flip the read_only default to true so fresh installs refuse mutating operations (CLI service commands, MCP write tools) and open database sessions read-only until the user opts in with
tiger config set read_only false.Existing installations are grandfathered: older CLI versions only wrote read_only to the config file when set explicitly, so a config file without the key predates the default flip and
MigrateReadOnly(same in-memory-shim pattern asMigrateVersionCheck) resolves it to false. To keep that detection sound, every config file written by Set/Unset/Reset now records read_only explicitly; unsetting or resetting restores the current default (true).