fix(ci): harden generated import workflow - #201
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the GitHub Actions workflow generated by me ci install (Memory Engine CLI) to reduce token exposure and to avoid relying on GitHub’s default workflow permissions, and adds regression tests to ensure the rendered workflow stays hardened.
Changes:
- Add an explicit workflow-level
permissions: contents: readblock to generated import workflows. - Disable
actions/checkoutcredential persistence viapersist-credentials: false. - Extend workflow-rendering tests to assert both hardening measures, and update the repo’s checked-in
me-import.ymlaccordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/cli/commands/project-ci.ts | Updates the workflow template rendered by me ci install to set explicit permissions and disable checkout credential persistence. |
| packages/cli/commands/project-ci.test.ts | Adds assertions to lock in the workflow hardening behavior as regression coverage. |
| .github/workflows/me-import.yml | Applies the newly hardened settings to this repo’s import workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Fixes TNT-230.