You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The /kafka-source#consume_schema_strategy link pattern into partial headings is well-established in this repo (#config_file, #named_collection are linked the same way), and underscore anchors match the existing convention.
The migration note calling out the default-behavior change is exactly the right thing to include for a breaking default.
The ssl_ca_pem typo fix and the grammar cleanup in kafka-schema-registry.md are nice drive-bys.
Issues
1. The raw-mode example is technically wrong (both copies). It strips the 5-byte Confluent header from an Avro-encoded payload, then routes it with json_extract_string(raw, ...). Avro binary is not JSON — json_extract_string will return nothing on it. Either the example should use a JSON-encoded payload scenario, or the routing should be shown on something that actually works on raw Avro bytes (e.g. schema-ID-based routing via a metadata column, or decoding in application logic as the prose suggests). As written, users will copy an MV that silently produces empty rows.
2. The two copies of the examples have already diverged.kafka-external-stream-read.md filters on json_extract_string(raw, '_schema_type') while kafka-external-stream.md filters on json_extract_string(raw, 'type'). Worse, both partials are included in the same rendered page: /kafka-source = Basics partial + Read partial, so the near-identical single/all/raw examples appear twice on one page. Suggest keeping the full reference in the settings section and reducing the Read-section addition to a short paragraph + link.
3. Read-side content now renders on the Kafka Sink page. The Basics partial (shared/kafka-external-stream.md) is imported by both kafka-external-stream-source.mdx and kafka-external-stream-sink.mdx, so ~100 lines about consumption strategy will appear on /kafka-sink too. If that's not intended, this content belongs in shared/kafka-external-stream-read.md (source-only) instead.
4. Internal contradiction on schema_subject_name requirement. The consume_schema_strategy table says single mode requires "schema_subject_name must be set" — but single is the default, and the subject_name_strategy table says the default TopicNameStrategyignoresschema_subject_name (subject is derived as <topic>-value). A reader can't tell what a plain registry-backed stream with no schema_subject_name does under the new default. Please clarify that the requirement only applies with RecordNameStrategy/TopicRecordNameStrategy.
5. No version marker. The PR body says "New in v3.4" and the all row says "preserves the pre-v3.4 behavior," but nowhere does the doc say the setting exists starting from 3.4. Repo convention is "Starting from Timeplus Enterprise X…" (see js-udf.md, py-udf.md). Users on 3.3 will try the setting and fail; kafka-schema-registry.md now also describes single-mode filtering as current behavior with no version gate. (enterprise-v3.4.md doesn't exist yet — the release-notes entry will presumably come separately, but the version marker here shouldn't wait for it.)
6. Minor: the Read partial's "see the Kafka External Stream settings" is a self-link on the /kafka-source page it renders into — harmless, but becomes unnecessary if the duplication in issue 2 is resolved.
Risk assessment
Medium for a docs PR: the copy-paste raw example would mislead users into a non-working pipeline (issue 1), and the on-page duplication (issue 2) plus sink-page bleed (issue 3) are structural. Recommend addressing issues 1–4 before merge, with 5 strongly encouraged.
Fixed the description for issue item 1 & 4
For item 2 & 3, remove the read examples in the shared content and keep only in the read page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #662
New in v3.4