Skip to content

Session suffices for upload — no app-specific password demands (v1.64.13.0)#43

Merged
time-attack merged 3 commits into
mainfrom
time-attack/appleship-no-asp
Jul 24, 2026
Merged

Session suffices for upload — no app-specific password demands (v1.64.13.0)#43
time-attack merged 3 commits into
mainfrom
time-attack/appleship-no-asp

Conversation

@time-attack

@time-attack time-attack commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Live nimbus round 7: the run stopped to demand an app-specific password, claiming Apple requires it for 2FA-account uploads. fastlane's own CI docs say either the ASP or a spaceauth session works — the session alone uploads via deliver/pilot. The guarantee sentence was lost in the v1.64.7.0 contract compression; this restores it and adds an attempt-first rule (credential fallback talk requires a real auth error from a real upload attempt, and preemptive ASP demands are a named violation). App Review contact info moves into the authorization moment + decision store instead of being a mid-run roadblock.

Test evidence: test:gstack2 gate green (parity 4,359).

🤖 Generated with Claude Code


Summary by cubic

Stop blocking Apple uploads by demanding an app-specific password. Use the existing spaceauth session, try upload first, and only ask for credentials if a real auth error occurs; also move App Review contact collection into the auth step and persist it.

  • Bug Fixes
    • Restore “session suffices for upload” guarantee; no preemptive ASP demands.
    • Enforce attempt-first auth: try the cached session before any fallback.
    • Clarify that deliver/pilot work with the session alone; only ask for ASP after a real auth failure.
    • Collect and persist App Review contact details during authorization; remove mid-run prompts.

Written for commit cd29450. Summary will update on new commits.

Review in cubic

Sinabina and others added 3 commits July 24, 2026 09:29
…demands

Restores the guarantee lost in the v1.64.7.0 rewrite, adds attempt-
first rule, folds review contact info into the authorization moment.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@time-attack
time-attack merged commit 2de5c36 into main Jul 24, 2026
0 of 2 checks passed
@cursor

cursor Bot commented Jul 24, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant