Session suffices for upload — no app-specific password demands (v1.64.13.0)#43
Merged
Conversation
…demands Restores the guarantee lost in the v1.64.7.0 rewrite, adds attempt- first rule, folds review contact info into the authorization moment. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live nimbus round 7: the run stopped to demand an app-specific password, claiming Apple requires it for 2FA-account uploads. fastlane's own CI docs say either the ASP or a spaceauth session works — the session alone uploads via deliver/pilot. The guarantee sentence was lost in the v1.64.7.0 contract compression; this restores it and adds an attempt-first rule (credential fallback talk requires a real auth error from a real upload attempt, and preemptive ASP demands are a named violation). App Review contact info moves into the authorization moment + decision store instead of being a mid-run roadblock.
Test evidence:
test:gstack2gate green (parity 4,359).🤖 Generated with Claude Code
Summary by cubic
Stop blocking Apple uploads by demanding an app-specific password. Use the existing spaceauth session, try upload first, and only ask for credentials if a real auth error occurs; also move App Review contact collection into the auth step and persist it.
deliver/pilotwork with the session alone; only ask for ASP after a real auth failure.Written for commit cd29450. Summary will update on new commits.