refactor: Remove legacy crates and dead code not used by Nori#230
Merged
refactor: Remove legacy crates and dead code not used by Nori#230
Conversation
Remove crates and feature-gated code that are never used in the Nori build: Removed crates: - app-server: HTTP server for standalone API mode - backend-client: OpenAI backend HTTP client - chatgpt: ChatGPT Canvas integration - cloud-tasks: Task management UI - codex-backend-openapi-models: Backend API types - exec: CLI execution mode - feedback: User feedback collection - lmstudio: LM Studio integration - mcp-server: MCP server mode - ollama: Ollama integration Removed dead feature-gated code: - feedback: UI popups and consent dialogs - codex-features: Provider hiding logic - upstream-updates: Update checker - backend-client: Rate limit fetching - oss-providers: OSS provider utilities Also removes the workspace lint workaround that allowed cfg references to these non-existent features. This cleanup reduces the codebase significantly while maintaining all functionality needed for the Nori ACP backend. 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
…uthored-By: Nori <contact@tilework.tech>
Resolve conflict in slash_command.rs by keeping our changes that remove the dead feature-gated code for feedback and codex-features.
The exec crate was removed as part of the legacy code cleanup.
Resolve conflicts between dev (adding vertical_footer feature) and remove-legacy-crates (removing feedback feature): - Accept vertical_footer parameter additions from dev - Remove feedback feature-gated code since this PR removes that feature Files resolved: - codex-rs/tui/src/app.rs - codex-rs/tui/src/app_backtrack.rs - codex-rs/tui/src/chatwidget.rs - codex-rs/tui/src/chatwidget/tests.rs - codex-rs/tui/src/lib.rs 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
This removes ~40,000 lines of code while maintaining all functionality needed for the Nori ACP backend.
Test Plan
cargo build -p codex-tuicompiles successfullycargo test -p codex-tui- 660 tests passjust fmtruns without errorsjust fix -p codex-tui -p codex-commonruns without clippy warningsShare Nori with your team: https://www.npmjs.com/package/nori-ai