GML-2067: Register PNG and GIF in TextExtractor supported MIME types#30
Closed
Bharath-Tigergraph wants to merge 1 commit intotigergraph:mainfrom
Closed
GML-2067: Register PNG and GIF in TextExtractor supported MIME types#30Bharath-Tigergraph wants to merge 1 commit intotigergraph:mainfrom
Bharath-Tigergraph wants to merge 1 commit intotigergraph:mainfrom
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
This change extends TextExtractor.supported_extensions in common/utils/text_extractors.py so .png (image/png) and .gif (image/gif) are recognized alongside existing JPEG handling.
Why: Ingestion and downstream processing rely on this map to treat uploads as supported image types. Without these entries, PNG (and GIF) files could be mishandled or rejected even when image extraction paths are otherwise correct.
Scope: Adds two MIME mappings only; no behavioral changes elsewhere in the module.
PR Type
Bug fix, Enhancement
Description
Register PNG and GIF MIME types
Extend
supported_extensionsmapping in initializerEnsure PNG/GIF ingestion and extraction work
No behavior changes elsewhere
Diagram Walkthrough
File Walkthrough
text_extractors.py
Add PNG and GIF MIME mappingscommon/utils/text_extractors.py
.png->image/pngmapping.gif->image/gifmapping