Tabular Deep Learning parameters#454
Conversation
- 11 parameter source files (R/param_*.R): bottleneck_units, dropout_attn, dropout_embedding, num_attn_blocks, num_attn_feat, num_attn_heads, num_embedding, penalty_average, penalty_type, resid_at, step_rate
- 11 corresponding Rd documentation files (man/*.Rd)
Modified files
Updates
- NEWS.md and _pkgdown.yml
- tests/testthat/test-params.R — 11 new range assertions + 1 values assertion
Roxygen2 cleanup (unrelated to our changes)
18 existing man/*.Rd files stripped of \docType{data}, \format{}, and \keyword{datasets} — side effect of running devtools::document() with a newer roxygen2
Adds attention_type(), dropout_hidden(), and dropout_last() parameters
| #' @inheritParams Laplace | ||
| #' | ||
| #' @details | ||
| #' Used as a tuning parameter for `tabular_auto_int()` in the `tdl` package |
There was a problem hiding this comment.
I guess it is time to make a call on the new package name: bartab tabular.
I'll update this and start the renaming process.
topepo
left a comment
There was a problem hiding this comment.
Looks good. I changed the package name from tdl
|
I usually do a separate PR for updating the roxygen2 version so that it's easier to check for diffs due to that vs diffs of other nature. I've updated this PR from main with those changes so that we now only have the changes related to the new parameters on here. Are all these parameters ones you expect to reuse across different engines or models? If not, could you please group them in a meaningful way? So far we've grouped by engine, that might also be right choice here. Grouping helps with navigating the options/docs and the code base. The rest is probably very straightforward and I'll take a look once we've established if they can be grouped. 🙌 |
Groups parameters in 4 families. Attention, RLN, Restnet, and the more generic ones into the existing param_network script
|
Hi @hfrick! Thanks! So the new groupings will be:
|
|
I have one more parameter to add. I'll put it in this PR today. |
Closes #452
SAINT (via
brulee):attention_type()- values:"column","row","both"dropout_hidden()- range:0,0.5dropout_last()- range:0,0.5tdlpackage (brulee engine):bottleneck_units()- range:2L,25Ldropout_attn()- range:0,0.5dropout_embedding()- range:0,0.5num_attn_blocks()- range:1L,6Lnum_attn_feat()- range:8L,64Lnum_attn_heads()- range:1L,8Lnum_embedding()- range:8L,64Lpenalty_average()- range:-15,-5(log10 scale)penalty_type()- values:"L1","L2"resid_at()- range:2L,unknown()step_rate()- range:0,8(log10 scale)All new parameters are added to the pkgdown reference index.
Several existing
.Rdfiles have incidental changes from roxygen2 dropping\docType{data}and\format{}blocks forvalues_*vectors.Example: