Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Android only:
Adding
paddingto the Ti.UI.ButtonButton 2 and 4 are default Ti buttons (without and with a custom background color). Currently there was no way to set a custom padding. Even worse: we've set the default padding for a button with background to a very small value for buttons with background color:
12.6.3.GA

(top: default color, bottom: custom background color).
Fix
This PR will set the default padding for a button with backgroundColor to the native padding again (first image, button 4) and gives the option to define a custom padding (first image, button 1 and 3).
Example
You can click Button 2 and 3 to test the property change.