Add max_memory_usage field to tidesdb_config_t#40
Closed
mukesh-2096 wants to merge 1 commit intotidesdb:masterfrom
Closed
Add max_memory_usage field to tidesdb_config_t#40mukesh-2096 wants to merge 1 commit intotidesdb:masterfrom
mukesh-2096 wants to merge 1 commit intotidesdb:masterfrom
Conversation
Member
|
That's correct. Good stuff, thank you |
Member
|
@mukesh-2096 one favor, can you put your new tests in test_tidesdb.lua, to be consistent. I do not like the new file, its random. Please follow the comment and code style. |
Contributor
Author
|
@guycipher |
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
max_memory_usageconfiguration field totidesdb_config_t, allowing users to set memory usage limits when opening a TidesDB database instance.Changes Made
size_t max_memory_usagefield to thetidesdb_config_tFFI structuretidesdb.default_config()to includemax_memory_usagewith a default value of0(unlimited)TidesDB.new()constructor to handle themax_memory_usageconfiguration parameterTidesDB.open()method to acceptmax_memory_usageas an option0indicates unlimited memory usageUsage Example