feat(unix): add Python version constraints and development environment#276
Open
feat(unix): add Python version constraints and development environment#276
Conversation
- Add python_requires=">=3.6,<3.12" to setup.py to enforce compatibility - Add Python version classifiers for better PyPI metadata - Document Python version requirements in README.md - Add dev-env.sh script for easy development environment setup This change addresses the incompatibility with Python 3.12+ due to Ansible 2.9.x dependency limitations. The project now officially supports Python 3.6 through 3.11.
There was a problem hiding this comment.
Pull Request Overview
Adds explicit Python version constraints and tooling for setting up a consistent development environment.
- Bumps package version and enforces Python 3.6–3.11 compatibility in setup.py
- Introduces a
dev-env.shscript for initializing Python with pyenv and installing the package in editable mode - Documents Python requirements in README.md
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| unix/setup.py | Bumped version, added python_requires and PyPI classifiers |
| unix/dev-env.sh | New script to bootstrap a development environment |
| unix/README.md | Added “Requirements” section with supported Python versions |
Comments suppressed due to low confidence (2)
unix/dev-env.sh:33
- The script echoes a
machine-statscommand, but the console entry point is defined asmachine_stats. Update the message or add a hyphenated entry point for consistency.
echo " machine-stats --help"
unix/dev-env.sh:1
- [nitpick] This new setup script introduces logic for environment setup but has no automated tests. Consider adding a CI job or integration test to verify pyenv initialization and editable install behavior.
#!/bin/bash
- Change the verification method for machine-stats installation from pip list to pip show for improved accuracy.
SamDesmondKing
approved these changes
Jul 7, 2025
Contributor
SamDesmondKing
left a comment
SamDesmondKing
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking care of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses the incompatibility with Python 3.12+ due to Ansible 2.9.x dependency limitations. The project now officially supports Python 3.6 through 3.11.