Skip to content

fix: App drawer closes upon account selection#10580

Merged
wmontwe merged 1 commit intothunderbird:mainfrom
mohitsatr:app-drawer-regression
Apr 13, 2026
Merged

fix: App drawer closes upon account selection#10580
wmontwe merged 1 commit intothunderbird:mainfrom
mohitsatr:app-drawer-regression

Conversation

@mohitsatr
Copy link
Copy Markdown
Contributor

@mohitsatr mohitsatr commented Feb 24, 2026

Fixes #10120

Behaviour:

Bin is set as AutoExpandFolder for both accounts

Screen_Recording_20260402_101406_Thunderbird.Debug.mp4

@mohitsatr mohitsatr force-pushed the app-drawer-regression branch from 42f12d8 to 12bb10f Compare March 9, 2026 08:25
@mohitsatr mohitsatr marked this pull request as ready for review March 9, 2026 08:25
@mohitsatr mohitsatr requested a review from a team as a code owner March 9, 2026 08:25
@mohitsatr mohitsatr requested a review from jbott-tbird March 9, 2026 08:25
@mohitsatr mohitsatr force-pushed the app-drawer-regression branch from 12bb10f to c739138 Compare March 9, 2026 08:27
@wmontwe wmontwe requested review from wmontwe and removed request for jbott-tbird March 10, 2026 15:45
@wmontwe wmontwe assigned wmontwe and unassigned jbott-tbird Mar 10, 2026
@mohitsatr mohitsatr force-pushed the app-drawer-regression branch from c739138 to e71ba41 Compare March 11, 2026 02:21
@mohitsatr
Copy link
Copy Markdown
Contributor Author

I feel creating a use case for getting the autoExpandAccount Id is an unnecessary abstraction. Is there a better way to do this?
In fact, we don't even need ID, just the boolean value to let us know whether or not AutoExpandAccount is set.

@wmontwe
Copy link
Copy Markdown
Member

wmontwe commented Mar 11, 2026

I feel creating a use case for getting the autoExpandAccount Id is an unnecessary abstraction. Is there a better way to do this? In fact, we don't even need ID, just the boolean value to let us know whether or not AutoExpandAccount is set.

A separate use case is not needed, you could update the GetDisplayAccounts and the DisplayAccount to hold that property.

@mohitsatr mohitsatr force-pushed the app-drawer-regression branch from e71ba41 to eef951b Compare April 2, 2026 04:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Missing report label. Set exactly one of: report: include, report: exclude OR report: highlight.

@mohitsatr
Copy link
Copy Markdown
Contributor Author

@wmontwe Please review

@wmontwe wmontwe added the report: include Include changes in user-facing reports. label Apr 7, 2026
@rafaeltonholo rafaeltonholo added the merge block: soft freeze PR to main is blocked: risky code or feature flag enablement must wait until soft freeze lifts. label Apr 7, 2026
@wmontwe wmontwe removed the merge block: soft freeze PR to main is blocked: risky code or feature flag enablement must wait until soft freeze lifts. label Apr 10, 2026
Copy link
Copy Markdown
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wmontwe wmontwe merged commit 64c0906 into thunderbird:main Apr 13, 2026
17 of 18 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 20 milestone Apr 13, 2026
@mohitsatr mohitsatr deleted the app-drawer-regression branch April 13, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: include Include changes in user-facing reports.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App drawer no longer closes upon account selection, regression??

4 participants