Support tweaked Taproot FROST deposit sweeps#4017
Open
mswilkison wants to merge 11 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on feat/frost-schnorr-migration-scaffold.
Adds Taproot tweak helpers and per-input merkle-root metadata for tweaked P2TR key-path inputs, routes wallet signing through root-aware FROST/tbtc-signer requests, and verifies native aggregates against the tweaked output key.
Also adds Taproot-native, refund-preserving deposit sweep support: Bridge/WalletProposalValidator bindings for TaprootDepositRevealed and validateTaprootDepositSweepProposal, Taproot refund script and merkle-root derivation, proposal generation that separates legacy and Taproot deposits, Taproot sweep assembly with per-input merkle roots, P2TR wallet main UTXO/change outputs, and Electrum script-based P2TR wallet UTXO discovery.
Verification: go test ./pkg/bitcoin ./pkg/tbtc ./pkg/tbtcpg ./pkg/chain/ethereum; go test ./pkg/...; go test -tags frost_native ./pkg/frost/signing ./pkg/tbtc -run 'TestMessageDigestFromBigInt|TestBuildTaggedLegacyCompatibleNativeExecutionFFISigningPrimitive_Sign_NativeFROSTPath|TestExecuteBuildTaggedTBTCSignerBootstrapCoarseRound|TestWalletTransactionExecutor_SignTransaction|TestSigningExecutor'; go test -tags 'frost_native frost_tbtc_signer cgo' ./pkg/frost/signing.