fix(tbtcpg/test): use constant format string in fmt.Errorf#3996
Open
piotr-roslaniec wants to merge 1 commit into
Open
fix(tbtcpg/test): use constant format string in fmt.Errorf#3996piotr-roslaniec wants to merge 1 commit into
piotr-roslaniec wants to merge 1 commit into
Conversation
`go vet` (run by `go test`) rejects `fmt.Errorf(unmarshaled.ExpectedErr)`
because the format string is not a compile-time constant. This caused
the `client-integration-test` job in CI to fail with:
pkg/tbtcpg/internal/test/marshaling.go:276:33:
non-constant format string in call to fmt.Errorf
Wrap the value in `%s` so the format string is a constant and the
package builds again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go vet(run automatically bygo test) rejectsfmt.Errorf(unmarshaled.ExpectedErr)because the format string is not a compile-time constant. This is what's currently breaking theclient-integration-testjob onmain:Which surfaces as
pkg/tbtcpg/internal/test [build failed]in the test output.Fix: wrap the dynamic string in
%sso the format string is constant.Test plan
go test -tags=integration -c -o /dev/null ./pkg/tbtcpg/internal/test/succeeds (previously failed)Clientworkflow no longer reportspkg/tbtcpg/internal/test [build failed]