ci(npm-random-beacon): pin @threshold-network/solidity-contracts to 1.2.1#3995
Open
piotr-roslaniec wants to merge 1 commit into
Open
ci(npm-random-beacon): pin @threshold-network/solidity-contracts to 1.2.1#3995piotr-roslaniec wants to merge 1 commit into
piotr-roslaniec wants to merge 1 commit into
Conversation
….2.1 The `development` dist-tag was bumped to 1.3.0-dev.16, which refactored `TokenStaking` so `approveApplication` is no longer exposed by the deployed ABI. The deploy script `solidity/random-beacon/deploy/05_approve_random_beacon_in_token_staking.ts` calls that function and fails the CI publish step. Pin to the last compatible version (1.2.1) so publishes succeed while the deploy scripts and Go ABI bindings are migrated to the 1.3 API in a separate PR.
piotr-roslaniec
force-pushed
the
chore/pin-threshold-solidity-contracts
branch
from
94d69cb to
25f64f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NPM Random Beaconworkflow has been failing onmainsince the@threshold-network/solidity-contractsdevelopmentdist-tag jumped from1.3.0-dev.11to1.3.0-dev.16.1.3.0-dev.16upstream refactoredTokenStakingsoapproveApplicationis no longer exposed by the deployed ABI, causingdeploy/05_approve_random_beacon_in_token_staking.tsto error out with:@threshold-network/solidity-contracts@1.3.0-dev.11— the exact version used by the last successful@keep-network/random-beaconpublish (2.1.0-dev.18). Unpinning should be done in a follow-up once the deploy scripts (and the Go ABI bindings inpkg/chain/ethereum/threshold/gen/) are migrated to the new TokenStaking API.Test plan
workflow_dispatch) succeeds at theDeploy contractsstepNPM Random Beaconworkflow onmainis green