fix(deps): address Semgrep supply chain security findings#3927
Open
piotr-roslaniec wants to merge 3 commits intothreshold-network:mainfrom
Open
fix(deps): address Semgrep supply chain security findings#3927piotr-roslaniec wants to merge 3 commits intothreshold-network:mainfrom
piotr-roslaniec wants to merge 3 commits intothreshold-network:mainfrom
Conversation
## Go modules - Upgrade github.com/ethereum/go-ethereum v1.13.15 -> v1.17.2 (fixes CVE-2026-22862, CVE-2026-22868, CVE-2026-26314) - Note: btcd CVE-2024-38365 requires separate refactoring effort; the existing replace directive pins to v0.22.3 which predates the v0.23 rewrite where the bug was introduced - Note: tss-lib is already replaced with threshold-network/tss-lib fork via replace directive (GHSA-h24c-6p6p-m3vx) ## JavaScript (yarn resolutions + npm overrides) - solidity/ecdsa, solidity/random-beacon: add yarn resolution for web3-eth-accounts@1.2.11 to remove scrypt-shim (MAL-2022-5972), add npm override for get-func-name>=2.0.2 (CVE-2023-43646) - solidity-v1/dashboard: upgrade axios ^0.21.2 -> ^1.8.2 (CVE-2026-25639); add overrides for http-cache-semantics>=4.1.1 (CVE-2022-25881), get-func-name>=2.0.2, terser>=4.8.1 (CVE-2022-25858), decompress>=4.2.1 (CVE-2020-12265) - solidity-v1: add overrides for http-cache-semantics>=4.1.1, get-func-name>=2.0.2 - token-stakedrop: add overrides for bsock>=0.1.10 (CVE-2023-50475), http-cache-semantics>=4.1.1, get-func-name>=2.0.2 Note: bsock@0.1.9 inside bcoin's bundledDependencies cannot be overridden via npm overrides; requires updating the bcoin fork
Upgrading go-ethereum beyond v1.14 introduces c-kzg-4844/v2 which requires CGO libraries not present in the Alpine Docker build image, causing the linker to fail during `make generate`. Reverting to v1.13.15 until the Dockerfile is updated to support the new deps. CVE-2026-22862, CVE-2026-22868, CVE-2026-26314 (go-ethereum) are tracked separately.
Replace malicious `scrypt-shim@github:web3-js/scrypt-shim` (MAL-2022-5972) resolved from codeload.github.com with the npm security placeholder `0.0.1-security` in solidity/ecdsa and solidity/random-beacon yarn.lock files. Restores lock files to main-branch state (valid npm registry references) to fix the CI SSH auth failure caused by the previous regenerated lock files containing git+ssh:// references to private repos. Also removes the `resolutions: web3-eth-accounts` field from both package.json files — it was not compatible with --frozen-lockfile CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses 20 Semgrep supply chain findings in keep-core across Go modules and JavaScript lock files.
Go modules
github.com/ethereum/go-ethereumKnown limitations (require separate PRs):
replaceworkaround that redirectsbtcdandbtcd/v2to compatible versions for transitive deps using the old btcec API. The existingreplace => v0.22.3predates the v0.23 rewrite where this bug was introduced.replacedirective usesgithub.com/threshold-network/tss-libfork instead of the vulnerablebnb-chain/tss-lib.JavaScript
scrypt-shim@0.1.0(ecdsa, random-beacon)web3-eth-accounts@1.2.11removes the depget-func-name@2.0.0>=2.0.2in ecdsa, solidity-v1, token-stakedrophttp-cache-semantics@4.0.x>=4.1.1in dashboard, solidity-v1, token-stakedropaxios@0.21.2(dashboard)^1.8.2terser@4.6.3(dashboard)>=4.8.1decompress@4.2.0(dashboard)>=4.2.1bsock@0.1.9(token-stakedrop)>=0.1.10for non-bundled; bundled copy inside bcoin fork cannot be overriddenTest plan
go build ./...)