Extract common parts of TokenStaking contract#1866
Closed
Conversation
Extracted parts related to authorization from TokenStaking to a KeepStaking contact. KeepStaking is a base contract containing common code used by different types of staking: KEEP Token and ETH only staking in keep-ecdsa.
The library used just one function that is defined in StakeDelegatable contract. We don't need to pull whole TokenStaking contract.
Member
Author
|
Closing this PR as the changes were covered by #1867 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts some parts of code (mostly authorizations) from TokenStaking to a common contract. The code is common and is used also for ETH staking implemented in keep-network/keep-ecdsa#483.
Refs: keep-network/keep-ecdsa#483