Allow dependent modules to specify Grafana version#218
Allow dependent modules to specify Grafana version#218dickdavis wants to merge 1 commit intothoughtbot:mainfrom
Conversation
clarissalimab
left a comment
There was a problem hiding this comment.
From the documentation, it says that if no version is specified, then it defaults to the latest version, but since we're explicitly defaulting it to null, I wonder how the module will take that - I think it will work, but that might be a breaking change if we don't confirm that.
You can test if your change works as expected by changing the source to your local clone of the repo using a relative path or you can reference your branch. Let us know how that goes :)
Thank you for your contribution!
Just wanted to follow up with you to let you know this is still on my radar. Trying to work in some testing this week. Apologies for the delay! |
This PR provides dependent modules with the ability to specify a Grafana version to support in the workspace.
We (Three Ships/Home Solutions) would like to upgrade our Grafana version from
9.4.7to the latest AWS-support Grafana version (10.4according to the docs linked to above). Ideally, we'd like to upgrade to the latest version, but the resource does not appear to support that.With this change, I believe we would just need to modify our module like so:
Please advise if this patch will achieve the outcome we are looking for. I'm a bit of a Terraform noob, so apologies if this patch is lacking; happy to make any necessary changes. Thanks!