feat: refine implicit association syntax to declare traits without factory keyword#1796
Open
vburzynski wants to merge 2 commits intomainfrom
Open
feat: refine implicit association syntax to declare traits without factory keyword#1796vburzynski wants to merge 2 commits intomainfrom
vburzynski wants to merge 2 commits intomainfrom
Conversation
This refines the implicit association syntax to make it possible to declare traits without having to use the special factory keyword. previously you would write: factory :comment do user factory: [:user, :admin], name: "Joe Slick" end which can now be simplified as: factory :comment do user :admin, name: "Joe Slick" end this mirrors how you would write this in the explicit syntax: factory :comment do association :user, :admin, name: "Joe Slick" end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refines the implicit association syntax to make it possible to declare traits without having to use the special factory keyword.
previously you would have to write:
which can now be simplified as:
this mirrors how you would write this in the explicit syntax:
I was inspired after looking at #1552 which, as of this writing, has been open since 2022.