Skip to content

feat: add support for producing kakfa messages asynchronously#3246

Closed
doriandekoning wants to merge 1 commit intothomaspoignant:mainfrom
doriandekoning:add-async-kafka-producer
Closed

feat: add support for producing kakfa messages asynchronously#3246
doriandekoning wants to merge 1 commit intothomaspoignant:mainfrom
doriandekoning:add-async-kafka-producer

Conversation

@doriandekoning
Copy link
Copy Markdown
Contributor

@doriandekoning doriandekoning commented Mar 27, 2025 •
edited
Loading

Description

Still work in progress, currently the syncproducer blocks sometimes for us causing significant request timeouts.

Closes issue(s)

Resolve #

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

@github-actions github-actions Bot requested a review from thomaspoignant March 27, 2025 09:52
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 27, 2025 •
edited
Loading

✅ Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 3830d82
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/67e52aaaaede1e0008fa9a62

@doriandekoning doriandekoning force-pushed the add-async-kafka-producer branch from 40933b2 to fc704e7 Compare March 27, 2025 09:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.57%. Comparing base (7912e94) to head (3830d82).
⚠️ Report is 1209 commits behind head on main.

Files with missing lines Patch % Lines
exporter/kafkaexporter/exporter.go 35.29% 10 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3246      +/-   ##
==========================================
- Coverage   85.15%   84.57%   -0.58%     
==========================================
  Files         121      122       +1     
  Lines        5666     5719      +53     
==========================================
+ Hits         4825     4837      +12     
- Misses        667      702      +35     
- Partials      174      180       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@doriandekoning doriandekoning force-pushed the add-async-kafka-producer branch from fc704e7 to 5918ed7 Compare March 27, 2025 10:32
@doriandekoning doriandekoning marked this pull request as draft March 27, 2025 10:33
@doriandekoning doriandekoning changed the title WIP: feat: add support for producing kakfa messages asynchronously feat: add support for producing kakfa messages asynchronously Mar 27, 2025
@doriandekoning doriandekoning force-pushed the add-async-kafka-producer branch 2 times, most recently from f5ced56 to 8510c80 Compare March 27, 2025 10:37
@doriandekoning doriandekoning force-pushed the add-async-kafka-producer branch from 8510c80 to 3830d82 Compare March 27, 2025 10:38
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 27, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@thomaspoignant thomaspoignant removed their assignment Apr 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added Stale When an issue is open for too long and removed Stale When an issue is open for too long labels May 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 4, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added Stale When an issue is open for too long and removed Stale When an issue is open for too long labels Aug 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 18, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added Stale When an issue is open for too long and removed Stale When an issue is open for too long labels Sep 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 1, 2026

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the Stale When an issue is open for too long label Jan 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 11, 2026

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions Bot closed this Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomaspoignant thomaspoignant Awaiting requested review from thomaspoignant

Assignees

No one assigned

Labels

Stale When an issue is open for too long

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doriandekoning @thomaspoignant