Get cache from disk to avoid cache overwriting.#95
Open
iurisilvio wants to merge 1 commit intotholo:masterfrom
Open
Get cache from disk to avoid cache overwriting.#95iurisilvio wants to merge 1 commit intotholo:masterfrom
iurisilvio wants to merge 1 commit intotholo:masterfrom
Conversation
|
Please consider contributing this fix or others to the revived project at coherent-oss. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #94.
The cache is always written to the same file, for each worker and for the controller.
Controller don't execute tests and never has cache. Each worker has part of the cache, so they must get current cache to update it instead of just write to it.
It's still possible to some overwrite happen because workers don´t have a global lock. The pytest-xdist suggests to use
filelockto solve this problem, but it is an external dependency.