Skip to content

Add initial devcontainer configuration#2388

Open
samiepaige91 wants to merge 2 commits intothirdweb-dev:developfrom
samiepaige91:v2-web3-onboard
Open

Add initial devcontainer configuration#2388
samiepaige91 wants to merge 2 commits intothirdweb-dev:developfrom
samiepaige91:v2-web3-onboard

Conversation

@samiepaige91
Copy link

@samiepaige91 samiepaige91 commented Mar 13, 2026

Description

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Summary by CodeRabbit

  • Chores
    • Added development container configuration to streamline local development environment setup.

@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

Walkthrough

This change adds a Dev Container configuration file at .devcontainer/devcontainer.json that specifies a base development environment image with no additional features enabled.

Changes

Cohort / File(s) Summary
Dev Container Configuration
.devcontainer/devcontainer.json
Adds Dev Container configuration specifying mcr.microsoft.com/devcontainers/universal:2 as the base image with an empty features object.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description lacks the required 'Description' section explaining what the devcontainer configuration does and why it's being added. Add a detailed description explaining the purpose of the devcontainer configuration, what it sets up, and the benefits it provides to developers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change - adding a devcontainer configuration file, which is the sole purpose of this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Author

@samiepaige91 samiepaige91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant