Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Zip Slip vulnerability in skills import#199

Open
thirdeyenation wants to merge 1 commit into
mainfrom
sentinel-zip-slip-skills-import-16947130442591053172
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Zip Slip vulnerability in skills import#199
thirdeyenation wants to merge 1 commit into
mainfrom
sentinel-zip-slip-skills-import-16947130442591053172

Conversation

@thirdeyenation

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: _unzip_to_temp_dir in helpers/skills_import.py uses z.extractall(target) without verifying member paths, leading to a Zip Slip vulnerability.
🎯 Impact: A malicious skill ZIP could overwrite critical system or application files by using directory traversal sequences (../) or absolute paths in the archive.
πŸ”§ Fix: Added explicit member path validation. It resolves the intended extraction path for each member and uses is_relative_to to ensure the member falls safely within the target extraction directory before calling extractall.
βœ… Verification: Verified using an isolated python script generating a malicious zip and confirming a ValueError is raised instead of extracting the malicious file.


PR created automatically by Jules for task 16947130442591053172 started by @thirdeyenation

Added explicit member path validation during extraction in `helpers/skills_import.py`. It resolves the intended extraction path for each member and uses `is_relative_to` to ensure the member falls safely within the target extraction directory before calling `extractall`.

Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant