Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Zip Slip (path traversal) in skills import#195

Open
thirdeyenation wants to merge 1 commit into
mainfrom
sentinel-fix-zip-slip-16453137044410793851
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Zip Slip (path traversal) in skills import#195
thirdeyenation wants to merge 1 commit into
mainfrom
sentinel-fix-zip-slip-16453137044410793851

Conversation

@thirdeyenation

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Zip Slip (Path Traversal) vulnerability in helpers/skills_import.py where zipfile.ZipFile.extractall() is called without path validation.
🎯 Impact: A maliciously crafted zip file could extract files outside the intended temporary directory, potentially overwriting sensitive system or application files.
πŸ”§ Fix: Iterated through the archive members and explicitly verified that each member's resolved path is contained within the intended target directory using Path.is_relative_to() before extracting.
βœ… Verification: Ran pytest tests/test_skills_runtime.py to ensure existing skill extraction functionality remains intact.


PR created automatically by Jules for task 16453137044410793851 started by @thirdeyenation

Fixed a path traversal vulnerability during skill ZIP archive extraction. Added validation to ensure extracted file paths resolve strictly within the intended temporary target directory using `Path.is_relative_to()`.

Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant