🛡️ Sentinel: [CRITICAL/HIGH] Fix Zip Slip in skills_import.py#190
🛡️ Sentinel: [CRITICAL/HIGH] Fix Zip Slip in skills_import.py#190thirdeyenation wants to merge 1 commit into
Conversation
Replaced `z.extractall(target)` with a secure extraction loop in `helpers/skills_import.py`. This verifies that all members extracted from a ZIP file stay within the intended extraction directory using `Path.is_relative_to()`, preventing Zip Slip (path traversal) vulnerabilities. Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Zip Slip (path traversal during ZIP extraction)
🎯 Impact: Arbitrary file write outside of the target extraction directory
🔧 Fix: Implemented secure ZIP extraction by verifying all resolved paths stay within the target directory.
✅ Verification: Verified using a custom isolated script running a mock zip with traversal.
PR created automatically by Jules for task 15903587217882268641 started by @thirdeyenation