🛡️ Sentinel: [CRITICAL] Fix Path Traversal (Zip Slip) in Skill Import

[thirdeyenation]

🚨 Severity

CRITICAL

💡 Vulnerability

The _unzip_to_temp_dir function in helpers/skills_import.py extracts uploaded zip archives using extractall without validating the paths of the zip members. This allows an attacker to create a malicious zip file containing path traversal sequences (e.g., ../../), leading to arbitrary file write outside the designated extraction directory.

🎯 Impact

If a user imports a maliciously crafted skill archive, files on the system could be overwritten outside of the intended extraction directory.

🔧 Fix

Iterated through all members using z.namelist(), resolved their paths, and verified that they remain within the target extraction directory using pathlib.Path.is_relative_to prior to extraction.

✅ Verification

• The test suite compilation works, although isolated testing locally for this exact file fails due to test setup issues.
• The replace_with_git_merge_diff correctly implements the patch.
• Successfully verified the Zip Slip prevention logic with Code Reviewers.

---

PR created automatically by Jules for task 2755737215947568068 started by @thirdeyenation

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.