π‘οΈ Sentinel: [CRITICAL] Fix path traversal in zip extraction#185
π‘οΈ Sentinel: [CRITICAL] Fix path traversal in zip extraction#185thirdeyenation wants to merge 1 commit into
Conversation
π¨ Severity: CRITICAL π‘ Vulnerability: Path traversal / Zip Slip vulnerability in `helpers/skills_import.py` zip extraction. π― Impact: An attacker could overwrite arbitrary files on the system outside the designated extraction directory if they supply a maliciously crafted zip file. π§ Fix: Validated all zip archive members against the target extraction directory before calling `extractall()`. β Verification: Ran a temporary Python script to assert a `ValueError` is raised on unsafe paths like `../unsafe.txt`. Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Path traversal / Zip Slip vulnerability in
helpers/skills_import.pyzip extraction.π― Impact: An attacker could overwrite arbitrary files on the system outside the designated extraction directory if they supply a maliciously crafted zip file.
π§ Fix: Validated all zip archive members against the target extraction directory before calling
extractall().β Verification: Ran a temporary Python script to assert a
ValueErroris raised on unsafe paths like../unsafe.txt.PR created automatically by Jules for task 8901489086939724182 started by @thirdeyenation