π‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Skill Importer#183
π‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in Skill Importer#183thirdeyenation wants to merge 1 commit into
Conversation
β¦ction Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Zip Slip (path traversal) vulnerability in
helpers.skills_import._unzip_to_temp_dir. The function previously calledz.extractall(target)without verifying whether the files inside the archive resolved to paths within the intendedtargetdirectory. A maliciously crafted zip file containing relative paths (like../escaped.txt) could write files outside the temporary directory, potentially overwriting sensitive system files or application code.π― Impact: An attacker could upload or point the skill importer to a malicious
.zipfile that overwrites any writable file on the system, potentially achieving remote code execution (RCE) or altering project configurations.π§ Fix: Explicitly iterate over
z.namelist()and compute the absolute, resolved path of each member before extraction usingos.path.realpath. Then, verify that each path resides within thetargetdirectory usingfiles.is_in_dir. If any path escapes, aValueErroris raised.β Verification: Tested isolated functionality by creating a dummy zip with
../escaped.txtand ensuring the modified function intercepts the extraction and raises the expected error.PR created automatically by Jules for task 9931150929452089158 started by @thirdeyenation