Merged
Conversation
lgirdwood
approved these changes
Feb 12, 2025
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
LGTM, I assume will be non draft after validation completes ?
Author
Yes, I will mark it as ready for review once internal validation is finished. Thanks! |
johnylin76
reviewed
Feb 13, 2025
tools/topology/topology1/m4/google_ctc_audio_processing_coef_default.m4
Outdated
Show resolved
Hide resolved
tools/topology/topology1/m4/google_ctc_audio_processing_coef_default.m4
Outdated
Show resolved
Hide resolved
eddy1021
force-pushed
the
ctc_tplg1
branch
3 times, most recently
from
a143d51 to
c445a92
Compare
Author
|
Finished validation. Ready for reviews now. |
eddy1021
requested review from
a team,
dbaluta,
kv2019i,
lbetlej,
mmaka1,
plbossart and
ranj063
as code owners
johnylin76
reviewed
Feb 19, 2025
added 2 commits
February 19, 2025 21:26
Add topology1 for CTC component. Signed-off-by: Eddy Hsu <eddyhsu@google.com>
Fix logging in ctc icp3. Signed-off-by: Eddy Hsu <eddyhsu@google.com>
lgirdwood
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add topology1 for CTC component.