Merged
Conversation
lyakh
requested review from
abonislawski,
bardliao,
dbaluta,
iuliana-prodan,
kv2019i,
lbetlej,
lgirdwood,
marcinszkudlinski,
mmaka1,
pblaszko,
plbossart and
singalsu
as code owners
Collaborator
Author
|
SOFCI TEST |
kv2019i
approved these changes
Feb 10, 2025
| @@ -230,7 +230,7 @@ static bool llext_manager_section_detached(const elf_shdr_t *shdr) | |||
| } | |||
Collaborator
There was a problem hiding this comment.
"doesn't the whole of struct module_data" ?
lgirdwood
reviewed
Feb 10, 2025
src/include/sof/lib_manager.h
Outdated
|
|
||
| struct lib_manager_mod_ctx { | ||
| void *base_addr; | ||
| void *base_addr; /* library storage address (DRAM) */ |
llext_manager_link() doesn't need the whole of struct module_data, it only needs a pointer to a pointer to struct llext. Modify it to only receive the scope, that it needs. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Add comments to two structure fields, whose meaning isn't immediately obvious otherwise. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Let llext_manager_mod_init() calculate mod_array itself internally, it has all the data for that. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Fix a typo, making it impossible to build eq_fir without eq_iir as LLEXT. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Modular TDFB needs additional exported symbols from Zephyr and SOF core. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Collaborator
Author
|
CI: a single alsabat failure on MTL https://sof-ci.01.org/sofpr/PR9818/build10635/devicetest/index.html , TGL nocodec skipped, a single suspend-resume failure on LNL https://sof-ci.01.org/sofpr/PR9818/build10633/devicetest/index.html and PTL not fully configured yet |
lgirdwood
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract a couple of simple changes from #9804