samples: detect_test: add check for comp_data_blob_handler_new()#10786
Open
abonislawski wants to merge 2 commits into
Open
samples: detect_test: add check for comp_data_blob_handler_new()#10786abonislawski wants to merge 2 commits into
abonislawski wants to merge 2 commits into
Conversation
abonislawski
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a potential NULL pointer dereference in the detect_test sample component by handling allocation failure from comp_data_blob_handler_new() and reusing the existing cleanup path, consistent with other blob-using components.
Changes:
- Add a NULL check after
comp_data_blob_handler_new(dev)intest_keyword_new(). - Log an error and
goto cd_failwhen the model handler allocation fails.
comp_data_blob_handler_new() can return NULL on allocation failure. test_keyword_new() passed the result directly to comp_init_data_blob() without checking, leading to a NULL pointer dereference. Add the missing check and route to the existing cd_fail cleanup path, matching the pattern used by dcblock, google_hotword_detect, and other blob-using components. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Remove redundant function names from log messages Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Member
Author
|
CI fail unrelated, Connection refused (MTL only), I will rerun when fixed |
tmleman
reviewed
May 18, 2026
abonislawski
force-pushed
the
fix/detect-test-null
branch
from
1d9c497 to
2a0dc1d
Compare
lgirdwood
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comp_data_blob_handler_new() can return NULL on allocation failure. test_keyword_new() passed the result directly to comp_init_data_blob() without checking, leading to a NULL pointer dereference. Add the missing check and route to the existing cd_fail cleanup path, matching the pattern used by dcblock, google_hotword_detect, and other blob-using components.