app: os_linux_overlay: use Linux log format by default#10501
app: os_linux_overlay: use Linux log format by default#10501kv2019i wants to merge 1 commit intothesofproject:mainfrom
Conversation
Add CONFIG_LOG_OUTPUT_FORMAT_LINUX_TIMESTAMP=y to the Linux overlay. This aligns the timestamp format between SOF firmware and host Linux kernel logs. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull request overview
This PR enables Linux-formatted timestamps in SOF firmware logs to align with host kernel log timestamps, improving log correlation and debugging.
Changes:
- Enables
CONFIG_LOG_OUTPUT_FORMAT_LINUX_TIMESTAMPin the Linux overlay configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
LHTM, Btw will there be a followup PR for GDB on LNL+
| # SOF Linux driver does not require FW to retain its | ||
| # state, so context save can be disabled | ||
| CONFIG_ADSP_IMR_CONTEXT_SAVE=n | ||
| CONFIG_LOG_OUTPUT_FORMAT_LINUX_TIMESTAMP=y |
There was a problem hiding this comment.
I think we can enable this Kconfig option as a project default or an intel_adsp default. It is already enabled for CAVS25, MTL, LNL, PTL, and WCL boards, and is likely just missing for NVL, so there is no need to differentiate it in the Linux overlay.
There was a problem hiding this comment.
Hmm, @abonislawski not sure if everybody is ok with the Linux format, but let me do a PR and allow people a chance to review.
|
#10505 was merged instead. |
3 participants
Add CONFIG_LOG_OUTPUT_FORMAT_LINUX_TIMESTAMP=y to the Linux overlay. This aligns the timestamp format between SOF firmware and host Linux kernel logs.