dp: Fixes for DP scheduling#10488
Merged
lgirdwood merged 2 commits intothesofproject:mainfrom Jan 19, 2026
Merged
Conversation
The DP task is started at pipeline start and stopped when the DP module is freed. Since the pipeline can be paused and resumed multiple times, DP task start may be called when the task is already queued/running. This commit allows the DP task to be scheduled even when it was already started. This fixes DP tests with multiple pipeline pause/resume cycles. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
requested review from
LaurentiuM1234,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
marcinszkudlinski,
mmaka1,
pblaszko and
plbossart
as code owners
The switch code is not needed because the comp_trigger() call above invokes comp_trigger_local(), which already contains the appropriate switch logic. The version in comp_trigger_local() is the correct implementation for DP, with schedule_task_cancel() call removed by thesofproject/sof@d99cea9. This commit fixes DP tests with DP modules located on secondary cores. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
force-pushed
the
dp_fixes
branch
from
8e90fb6 to
bd2bdca
Compare
serhiy-katsyuba-intel
requested review from
abonislawski,
lyakh,
softwarecki and
tmleman
lyakh
reviewed
Jan 19, 2026
lgirdwood
approved these changes
Jan 19, 2026
| goto out; | ||
|
|
||
| /* schedule or cancel task */ | ||
| switch (cmd) { |
Member
There was a problem hiding this comment.
nitpick: we would not be able to validate the cmd type, but we didn't do this anyway
softwarecki
approved these changes
Jan 19, 2026
Collaborator
softwarecki
left a comment
softwarecki
left a comment
There was a problem hiding this comment.
Looks good. The solution is clean and easy to follow. Appreciate the remove the large switch-case. No further comments from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DP task is started at pipeline start and stopped when the DP module is freed. Since the pipeline can be paused and resumed multiple times, DP task start may be called when the task is already queued/running.
This commit allows the DP task to be scheduled even when it was already started. This fixes DP tests with multiple pipeline pause/resume cycles.
The switch code is not needed because the comp_trigger() call above invokes comp_trigger_local(), which already contains the appropriate switch logic. The version in comp_trigger_local() is the correct implementation for DP, with schedule_task_cancel() call removed by d99cea9.
This commit fixes DP tests with DP modules located on secondary cores.