modules: module_adapter: Remove redundant exports of internal functions#10435
Draft
softwarecki wants to merge 1 commit intothesofproject:mainfrom
Draft
modules: module_adapter: Remove redundant exports of internal functions#10435softwarecki wants to merge 1 commit intothesofproject:mainfrom
softwarecki wants to merge 1 commit intothesofproject:mainfrom
Conversation
Remove redundant exports of internal module adapter functions. Loadable modules expose the module_interface interface, which is used by the module adapter. They do not need to call any module_adapter functions directly because they do not provide the comp_driver interface. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
requested review from
abonislawski,
lyakh,
serhiy-katsyuba-intel,
tmleman and
wjablon1
softwarecki
added
need info
Collaborator
|
@softwarecki in principle - yes, I do think many of those symbols don't need to be exported, not sure any more why I exported them all. OTOH this seems to break something https://sof-ci.01.org/sofpr/PR10435/build17999/devicetest/index.html but strangely only for SDW, not for HDA, so that also might be a CI issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant exports of internal module adapter functions.
Loadable modules expose the module_interface interface, which is used by the module adapter. They do not need to call any module_adapter functions directly because they do not provide the comp_driver interface.