Tools: ctl: Add missing DRC blob speaker_default.txt#10418
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Dec 5, 2025
Merged
Tools: ctl: Add missing DRC blob speaker_default.txt#10418lgirdwood merged 1 commit intothesofproject:mainfrom
lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
This patch adds the proper blob speaker_default.txt that matches with UCMv2 blob speaker_default.bin. The incorrect format blob generic_notebook_spoeaker.txt with no TLV header is removed. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
There was a problem hiding this comment.
Pull request overview
This PR corrects DRC (Dynamic Range Control) configuration files by adding the proper speaker_default.txt blob that matches the UCMv2 binary format and removing an incorrectly formatted generic_notebook_speaker.txt file that was missing the required TLV header.
Key Changes
- Added new
speaker_default.txtfile with proper TLV header format (starting with3,140,) - Removed incorrectly formatted
generic_notebook_speaker.txtthat lacked the TLV header
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/ctl/ipc4/drc/speaker_default.txt | New file containing DRC blob with proper TLV header format matching UCMv2 binary |
| tools/ctl/ipc4/drc/generic_notebook_speaker.txt | Removed incorrectly formatted DRC blob missing TLV header |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
That works, thanks! |
lgirdwood
approved these changes
Dec 5, 2025
lyakh
approved these changes
Dec 5, 2025
Member
|
Not tested by internal CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the proper blob speaker_default.txt that matches with UCMv2 blob speaker_default.bin.
The incorrect format blob generic_notebook_spoeaker.txt with no TLV header is removed.