lib: fast-get: fix userspace build#10406
Conversation
CONFIG_SOF was removed in upstream Zephyr and this broke builds with user-space overlay. Fixes: 60780a6 ("west.yml: update zephyr to f3b9d1871104") Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull request overview
This PR fixes a userspace build breakage caused by the removal of CONFIG_SOF in upstream Zephyr. The fix updates the preprocessor condition to use CONFIG_SOF_FULL_ZEPHYR_APPLICATION instead.
- Replaced deprecated
CONFIG_SOFmacro withCONFIG_SOF_FULL_ZEPHYR_APPLICATION
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@lyakh @softwarecki @lgirdwood Would be nice to get #10119 (or something similar) merged, so we could catch this type of problems in pull request CI... |
Think we are just pending a CI pass, it has approvals. |
softwarecki
left a comment
softwarecki
left a comment
There was a problem hiding this comment.
This PR has a title very similar to the recently merged
which initially caused confusion because I thought that one was already merged. Indeed, there is a build issue that this PR fixes.
|
@lgirdwood @lyakh The CI had failures on this still, we will need to follow-up. E.g. https://github.com/thesofproject/sof/actions/runs/19824062171/job/56792943080?pr=10406 |
6 participants
CONFIG_SOF was removed in upstream Zephyr and this broke builds with user-space overlay.
Fixes: 60780a6 ("west.yml: update zephyr to f3b9d1871104")