[SKIP SOFCI-TEST] github: workflows: disable sparse checks temporarily#10337
Merged
kv2019i merged 1 commit intothesofproject:mainfrom Oct 29, 2025
Merged
[SKIP SOFCI-TEST] github: workflows: disable sparse checks temporarily#10337kv2019i merged 1 commit intothesofproject:mainfrom
kv2019i merged 1 commit intothesofproject:mainfrom
Conversation
Disable the sparse checks as they have been failing for 3 months due to zephyrproject-rtos/zephyr#93444 . Work to resolve the issue is still ongoing, so keep the definitions still in place. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202510-ci-disable-sparse
branch
from
41b52b5 to
d7659dc
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily disables sparse checks in the GitHub Actions workflow due to persistent failures related to an upstream Zephyr issue (#93444). The workflow configuration is retained for future re-enablement once the issue is resolved.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jobs: | ||
| # disable until https://github.com/zephyrproject-rtos/zephyr/issues/93444 | ||
| # is fixed | ||
| if: false |
There was a problem hiding this comment.
The if: false statement is incorrectly placed at the file level between jobs: and the job definition. This will cause a syntax error. It should be placed within a specific job definition. Move this line and the preceding comments to be indented under the job name (e.g., after the job key on the next line).
lyakh
approved these changes
Oct 29, 2025
tmleman
approved these changes
Oct 29, 2025
marc-hb
added a commit
to marc-hb/sof
that referenced
this pull request
Dec 9, 2025
Fixes commit 56649f6 ("github: workflows: disable sparse checks temporarily") which caused a syntax error GitHub jobs can be disabled one by one but not all at once: https://docs.github.com/en/actions/reference/workflows-and-actions/ workflow-syntax#jobsjob_idif This syntax error was found by Copilot; quoting: thesofproject#10337 (comment) > The if: false statement is incorrectly placed at the file level > between jobs: and the job definition. This will cause a syntax > error. It should be placed within a specific job definition. Move this > line and the preceding comments to be indented under the job > name (e.g., after the job key on the next line This has blocked daily tests from running for ages: https://github.com/thesofproject/sof/actions/runs/20048113632 ``` Invalid workflow file: .github/workflows/daily-tests.yml#L42 error parsing called workflow ".github/workflows/daily-tests.yml" -> "./.github/workflows/sparse-zephyr.yml" (source branch with sha:e00764e7fbe3315c0d8e1fa87624aec4e37db7e3) : (Line: 17, Col: 7): Unexpected value 'false' ``` Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Trivial fix #10424, please review. |
kv2019i
pushed a commit
that referenced
this pull request
Dec 10, 2025
Fixes commit 56649f6 ("github: workflows: disable sparse checks temporarily") which caused a syntax error GitHub jobs can be disabled one by one but not all at once: https://docs.github.com/en/actions/reference/workflows-and-actions/ workflow-syntax#jobsjob_idif This syntax error was found by Copilot; quoting: #10337 (comment) > The if: false statement is incorrectly placed at the file level > between jobs: and the job definition. This will cause a syntax > error. It should be placed within a specific job definition. Move this > line and the preceding comments to be indented under the job > name (e.g., after the job key on the next line This has blocked daily tests from running for ages: https://github.com/thesofproject/sof/actions/runs/20048113632 ``` Invalid workflow file: .github/workflows/daily-tests.yml#L42 error parsing called workflow ".github/workflows/daily-tests.yml" -> "./.github/workflows/sparse-zephyr.yml" (source branch with sha:e00764e7fbe3315c0d8e1fa87624aec4e37db7e3) : (Line: 17, Col: 7): Unexpected value 'false' ``` Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable the sparse checks as they have been failing for 3 months due to zephyrproject-rtos/zephyr#93444 . Work to resolve the issue is still ongoing, so keep the definitions still in place.