Skip to content

zephyr: stop using CONFIG_SOF to identify Zephyr build (w/ Zephyr Nov/20 update) #10335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 3 commits into from
Nov 24, 2025
Merged

zephyr: stop using CONFIG_SOF to identify Zephyr build (w/ Zephyr Nov/20 update) #10335

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce5b5fa
zephyr: stop using CONFIG_SOF to identify Zephyr build
kv2019i Oct 28, 2025
7b94e1d
test: ztest: fix ztest/unit tests to build when CONFIG_SOF is removed
kv2019i Nov 18, 2025
628afcd
west.yml: update zephyr to f3b9d1871104
kv2019i Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
CONFIG_SOF=y
CONFIG_BUILD_OUTPUT_BIN=n
CONFIG_SOF=y
Copy link
Copy Markdown
Collaborator

@lyakh lyakh Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this hunk can be dropped, and the commit title should be updated?

Copy link
Copy Markdown
Collaborator Author

@kv2019i kv2019i Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh It's just moved to the last patch. I have to split this into multiple patches not to break bisect. If I remove CONFIG_SOF in a different commit than the zepyr west.yaml, I break bisect.

Copy link
Copy Markdown
Collaborator

@lyakh lyakh Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i I understand why you keep CONFIG_SOF=y but I don't think swapping the lines in the file is needed? ;-) So you could just drop this hunk and leave the file unchanged - first line CONFIG_SOF=y, second line CONFIG_BUILD_OUTPUT_BIN=n


# The additional stripped .elf files are deterministic.
# This adds very few files in the build directory and has
Expand Down
4 changes: 2 additions & 2 deletions zephyr/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# compile every Zephyr module that can be found. See
# sof/zephyr/module.yml and
# https://docs.zephyrproject.org/latest/develop/modules.html
if(CONFIG_SOF)
if(CONFIG_SOF_FULL_ZEPHYR_APPLICATION)

if(CONFIG_ZEPHYR_POSIX)
set(ARCH host)
Expand Down Expand Up @@ -567,4 +567,4 @@ include(../scripts/cmake/uuid-registry.cmake)
# Create Trace realtive file paths
sof_append_relative_path_definitions(modules_sof)

endif() # CONFIG_SOF
endif() # CONFIG_SOF_FULL_ZEPHYR_APPLICATION
10 changes: 7 additions & 3 deletions zephyr/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
if SOF
config SOF_FULL_ZEPHYR_APPLICATION
bool "Build full SOF Zephyr application"
default y
help
Top-level build option to enable full build of the SOF application
on top of Zephyr. This should be set to no only for unit test and
such special build targets.

Copy link
Copy Markdown
Contributor

@ujfalusi ujfalusi Nov 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you retain the if here and the endif:

if SOF_FULL_ZEPHYR_APPLICATION

or better:

menuconfig SOF_FULL_ZEPHYR_APPLICATION
	bool "Build full SOF Zephyr application"
	default y
	help
	  Top-level build option to enable full build of the SOF application
	  on top of Zephyr. This should be set to no only for unit test and
	  such special build targets.

if SOF_FULL_ZEPHYR_APPLICATION
...
endif

Copy link
Copy Markdown
Collaborator Author

@kv2019i kv2019i Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ujfalusi I left this out on purposew. There are some Kconfigs that are useful to be availlable for SOF ztest type of uses and with PR, these can now be left defined (but set to "n" in the test configs if not needed).

It seems CI is all good with this as well, so I'd say the less ifdefs the better.

config SOF_STAGING
bool "Enable SOF staging features and modules"
Expand Down Expand Up @@ -203,5 +209,3 @@ config STACK_SIZE_IPC_TX
default 2048
help
IPC sender work-queue thread stack size. Keep a power of 2.

endif