Module api conversion of TDFB, template, tensorflow, and up down mixer modules. by jsarha · Pull Request #10296 · thesofproject/sof

jsarha · 2025-10-10T11:58:28Z

No description provided.

Copilot

Pull Request Overview

This PR converts several audio modules (TDFB, template, tensorflow, up down mixer, and volume) to use a new module-based memory allocation API. The changes replace direct memory allocation calls with module-aware allocation functions and remove manual memory cleanup since the module framework now handles this automatically.

Key changes:

Replace rzalloc(), rmalloc(), and rballoc() with mod_zalloc(), mod_alloc(), and mod_balloc()
Remove manual rfree() calls as memory is now managed by the module framework
Update function signatures to pass module context where needed for allocation

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/audio/volume/volume_ipc4.c	Convert volume IPC4 module to use module allocators and remove manual memory management
src/audio/volume/volume_ipc3.c	Convert volume IPC3 module to use module allocators and remove manual memory management
src/audio/volume/volume.c	Remove manual memory cleanup from volume module free function
src/audio/up_down_mixer/up_down_mixer.c	Convert up/down mixer to use module allocators and simplify error handling
src/audio/tensorflow/tflm-classify.c	Convert TensorFlow module to use module allocators and remove manual cleanup
src/audio/template/template.c	Convert template module to use module allocators and remove manual cleanup
src/audio/tdfb/tdfb_ipc3.c	Convert TDFB IPC3 control data allocation to use module allocator
src/audio/tdfb/tdfb_direction.c	Convert TDFB direction estimation to use module allocators and update function signature
src/audio/tdfb/tdfb_comp.h	Update TDFB direction init function signature and remove free function declaration
src/audio/tdfb/tdfb.c	Convert main TDFB module to use module allocators and remove manual cleanup

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/audio/tensorflow/tflm-classify.c

singalsu

Looks good to me, thanks!

lgirdwood · 2025-10-22T13:20:44Z

@jsarha can you check CI on LNL. Lots of red.

jsarha · 2025-10-22T21:02:40Z

SOFCI TEST

jsarha · 2025-10-23T10:21:05Z

Dropped volume module to a separate PR to understand the CI failures better: #10323

jsarha · 2025-10-23T13:48:41Z

src/audio/tdfb/tdfb.c


 		/* Allocate all FIR channels data in a big chunk and clear it */
-		cd->fir_delay = rballoc(SOF_MEM_FLAG_USER, delay_size);
+		cd->fir_delay = mod_balloc(mod, delay_size);


This line will crash without this fix: #10324

lyakh · 2025-10-27T10:56:18Z

src/audio/tdfb/tdfb.c

 	ret = tdfb_ipc_notification_init(mod);
 	if (ret)
-		goto err_free_cd;
+		return ret;


same issue as in multiple other PRs

lyakh · 2025-10-27T10:57:20Z

src/audio/tensorflow/tflm-classify.c

-		ret = -ENOMEM;
-		goto cd_fail;
+		comp_err(dev, "mod_data_blob_handler_new() failed.");
+		return -ENOMEM;


potentially problematic too?

lyakh · 2025-10-27T10:58:10Z

src/audio/up_down_mixer/up_down_mixer.c

+	cd->buf_in = mod_balloc(mod, mod->priv.cfg.base_cfg.ibs);
+	cd->buf_out = mod_balloc(mod, mod->priv.cfg.base_cfg.obs);
+	if (!cd->buf_in || !cd->buf_out)
+		return -ENOMEM;


lyakh

fixed by #10320

softwarecki

Requires adjustment based on changes made in #10323.

jsarha · 2025-10-31T23:39:04Z

@softwarecki

Requires adjustment based on changes made in #10323.

These new versions of module conversions use module API to allocate the resources, but the code still has all the resource freeing code in place.

couple of memory leaks due to incomplete clean up code fixed

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Fix data blob handler leak in init failure. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Fix memory leaks from failed initialization. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

jsarha · 2025-11-03T14:40:19Z

Rebased on top of latest main branch to get #10347 fix in.

lgirdwood · 2025-11-03T17:17:29Z

Requires adjustment based on changes made in #10323.

@softwarecki now done.

@softwarecki

Changes requested by @softwarecki have now all been made and integrated so -1 is no longer needed.

Copilot AI review requested due to automatic review settings October 10, 2025 11:58

jsarha requested review from abonislawski, dbaluta, kv2019i, lbetlej, lgirdwood, mmaka1, plbossart and singalsu as code owners October 10, 2025 11:58

Copilot AI reviewed Oct 10, 2025

View reviewed changes

src/audio/tensorflow/tflm-classify.c Outdated Show resolved Hide resolved

jsarha force-pushed the module_api_tdfb_template_tensorflow_updownmixer_volume branch from 4715d52 to 7bfc9e6 Compare October 21, 2025 21:45

lgirdwood approved these changes Oct 22, 2025

View reviewed changes

jsarha mentioned this pull request Oct 22, 2025

Module api convert of aria, asrc, and copier #10284

Merged

singalsu approved these changes Oct 22, 2025

View reviewed changes

kv2019i approved these changes Oct 22, 2025

View reviewed changes

jsarha force-pushed the module_api_tdfb_template_tensorflow_updownmixer_volume branch 2 times, most recently from 023efff to 6691f9d Compare October 23, 2025 10:07

jsarha changed the title ~~Module api conversion of TDFB, template, tensorflow, up down mixer, and volume modules.~~ Module api conversion of TDFB, template, tensorflow, and up down mixer modules. Oct 23, 2025

jsarha commented Oct 23, 2025

View reviewed changes

lyakh requested changes Oct 27, 2025

View reviewed changes

lyakh approved these changes Oct 27, 2025

View reviewed changes

softwarecki previously requested changes Oct 31, 2025

View reviewed changes

jsarha force-pushed the module_api_tdfb_template_tensorflow_updownmixer_volume branch from 6691f9d to 2e620f4 Compare October 31, 2025 23:37

lgirdwood approved these changes Nov 3, 2025

View reviewed changes

Jyri Sarha added 2 commits November 3, 2025 16:38

Audio: TDFB: Memory, blob, and fast_get allocs to module API

0742a85

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Audio: TDFB: Fix data blob handler leak in init failure.

c46da87

Fix data blob handler leak in init failure. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Jyri Sarha added 4 commits November 3, 2025 16:38

Audio: Template_comp: Memory, blob, and fast_get allocs to module API

3b884a3

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

modules: tensorflow: Memory, blob, and fast_get allocs to module API

684fda1

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

modules: tensorflow: Fix memory leaks from failed initialization

35d0185

Fix memory leaks from failed initialization. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

Audio: up_down_mixer: Memory, blob, and fast_get allocs to module API

b8f0958

Allocate all memory, blob handlers, and fast_get() buffers through module API mod_alloc() and friends. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>

jsarha force-pushed the module_api_tdfb_template_tensorflow_updownmixer_volume branch from 2e620f4 to b8f0958 Compare November 3, 2025 14:38

lgirdwood approved these changes Nov 3, 2025

View reviewed changes

lgirdwood merged commit 1f83b15 into thesofproject:main Nov 4, 2025
39 of 42 checks passed

Conversation

jsarha commented Oct 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

singalsu left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented Oct 22, 2025

Uh oh!

jsarha commented Oct 22, 2025

Uh oh!

jsarha commented Oct 23, 2025

Uh oh!

jsarha Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lyakh Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

lyakh Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

lyakh Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

lyakh left a comment

Choose a reason for hiding this comment

Uh oh!

softwarecki left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsarha commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsarha commented Nov 3, 2025

Uh oh!

lgirdwood commented Nov 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jsarha Oct 23, 2025 •

edited

Loading

softwarecki left a comment •

edited

Loading

jsarha commented Oct 31, 2025 •

edited

Loading