app: boards: share common audio build options for Intel ADSPs#10209
Merged
lgirdwood merged 2 commits intothesofproject:mainfrom Sep 8, 2025
Merged
app: boards: share common audio build options for Intel ADSPs#10209lgirdwood merged 2 commits intothesofproject:mainfrom
lgirdwood merged 2 commits intothesofproject:mainfrom
Conversation
Remove unnecessary 'n' defaults in audio modules. This doesn't affect any current build as 'n' is the default if not set otherwise. By removing the unconditional defaults, it becomes possible to set defaults later in board/family specific Kconfig.defconfig files. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
SOF builds currently use the board Kconfig file to set any target specific build options. This includes modifying Zephyr build options (if different from Zephyr defaults for the SoC) and setting SOF specific options. There is currently no way to share definitions. For Intel ADSP boards, there starts to be a lot of boards and a lot of duplication of settings. Add a new mechanism to include common Kconfig.defconfig for a family of boards. Start with addition of boards/intel_adsp/Kconfig.defconfig and move common defaults for SOF audio modules to the common file. These are options that are not related to hardware features, but we want to set them in the same way for all Intel ADSP targets. Follow-up patches will move more options to the common Kconfig.defconfig and other vendors can add their own board family defconfig files. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
a team,
abonislawski,
dbaluta,
jxstelter,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
ranj063
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR implements shared common audio build options for Intel ADSPs to reduce code duplication across board configurations. The changes centralize default configuration values that were previously duplicated in individual board configuration files.
- Removes redundant
default nstatements from Kconfig files since this is the implicit default - Creates a centralized defconfig file for Intel ADSP platforms with common audio component defaults
- Removes duplicated configuration lines from individual Intel ADSP board files
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/boards/intel_adsp/Kconfig.defconfig | New centralized defconfig file defining common Intel ADSP audio defaults |
| app/Kconfig | Adds conditional inclusion of Intel ADSP defconfig |
| Multiple audio Kconfig files | Removes redundant default n statements |
| Multiple board .conf files | Removes duplicated configuration options now handled centrally |
| Kconfig.sof | Removes redundant default n for FAST_GET |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tmleman
approved these changes
Sep 2, 2025
lgirdwood
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to RFC PR #10182
This starts with audio component build options that are common to all Intel DSPs.