Audio: SRC: Add conversions from 8 - 192 kHz to 64 kHz#10130
Merged
lgirdwood merged 3 commits intothesofproject:mainfrom Jul 23, 2025
Merged
Audio: SRC: Add conversions from 8 - 192 kHz to 64 kHz#10130lgirdwood merged 3 commits intothesofproject:mainfrom
lgirdwood merged 3 commits intothesofproject:mainfrom
Conversation
If a non-supported conversion is requested the sizes to allocate and copy are zero. This addition prints a more descriptive error for the situation. Without this change the next null check printed more confusing error "failed to allocate coefficients". Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds to coefficients generator script sof_src_ipc4.m the conversions for 8 - 192 kHz to 64 kHz rate. It has been missing previously. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds the header files with coefficients for supported new rate conversions from 8 - 192 kHz to 64 kHz. Only the headers with changed coefficients values are included. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Collaborator
Author
|
@lgirdwood I added new coefficients into the latest push. To minimize the changes I had to use another computer to generate with Matlab the coefficients since they were previously generated with it. With Octave with other FIR tool in practice all coefficients would have changed. |
Collaborator
Author
|
Test results for new conversions with testbench and I'll change this to non-draft. |
golowanow
approved these changes
Jul 23, 2025
Member
golowanow
left a comment
There was a problem hiding this comment.
this change resolves a problem we've observed at 64 kHz rate set on a PCM
lyakh
approved these changes
Jul 23, 2025
abonislawski
approved these changes
Jul 23, 2025
lgirdwood
approved these changes
Jul 23, 2025
Member
|
SOFCI TEST |
Collaborator
Author
Excellent, thanks for testing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.