check-capture: add sample rate changing, topology changing#1304
Conversation
pkunieck
commented
Sep 23, 2025
pkunieck
commented
- Added functionality to change topology filename.
- Implemented sample rate modification.
- Enable ultrasound testing capabilities.
|
Can one of the admins verify this patch?
|
pkunieck
force-pushed
the
add_test_ultrasound_dmic_capture
branch
from
0eea1d5 to
1c495b6
Compare
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Interesting idea but I don't think this the swap should be done every time for each test. IMHO the higher level test framework should have test plans doing something like this:
- Perform the swap using a new script added here. Save the older file, state etc.
- Run any combination of tests without reloading drivers every time. Run just one test if desired.
- Restore previous topology.
In other words, I think the topology file belongs to the "test fixture".
About test plans, see Intel internal sof-framework issue 602.
case-lib/lib.sh
Outdated
| firmware_dir="/lib/firmware/intel/" | ||
| modprobe_file="/etc/modprobe.d/tplg_filename.conf" | ||
| remove_script="/home/ubuntu/sof-test/tools/kmod/sof_remove.sh" | ||
| insert_script="/home/ubuntu/sof-test/tools/kmod/sof_insert.sh" |
There was a problem hiding this comment.
$SCRIPT_HOME at the top of this file.
There was a problem hiding this comment.
Thanks for the feedback.
I’ve updated the paths as suggested. Regarding moving the topology swap logic into a separate script and higher-level test plan, I understand your point. In this case, though, the feature was mainly added to support ultrasound handling, and it’s not expected to be used frequently. Because of that, I’m not sure it’s worth introducing a full fixture-level implementation right now.
pkunieck
force-pushed
the
add_test_ultrasound_dmic_capture
branch
from
1c495b6 to
eecee05
Compare
pkunieck
force-pushed
the
add_test_ultrasound_dmic_capture
branch
from
eecee05 to
e20a7f9
Compare
pkunieck
force-pushed
the
add_test_ultrasound_dmic_capture
branch
from
e20a7f9 to
42cdc78
Compare
- Added functionality to change topology filename. - Implemented sample rate modification. - Enable ultrasound testing capabilities. Signed-off-by: Patryk Kuniecki <patryk.kuniecki@intel.com>
pkunieck
force-pushed
the
add_test_ultrasound_dmic_capture
branch
from
42cdc78 to
6f164a3
Compare
|
Please rebase, thx. |
6 participants
