latency tests: Clean up jackd on test setup#1299
Merged
KamilxPaszkiet merged 1 commit intothesofproject:mainfrom Sep 11, 2025
Merged
latency tests: Clean up jackd on test setup#1299KamilxPaszkiet merged 1 commit intothesofproject:mainfrom
KamilxPaszkiet merged 1 commit intothesofproject:mainfrom
Conversation
PLangowski
requested review from
a team,
golowanow,
lgirdwood and
marc-hb
as code owners
Collaborator
|
Can one of the admins verify this patch?
|
redzynix
approved these changes
Sep 5, 2025
Contributor
|
Please do a rebase. |
PLangowski
force-pushed
the
latency-cleanup-jackd
branch
from
da2d79d to
8342ec6
Compare
Contributor
Author
|
@redzynix rebased |
arikgreen
approved these changes
Sep 11, 2025
redzynix
reviewed
Sep 11, 2025
test-case/latency-metrics.sh
Outdated
|
|
||
| main() | ||
| { | ||
| pkill jackd |
Contributor
There was a problem hiding this comment.
Suggested change
| pkill jackd | |
| pkill jackd || True |
Sometimes when timeout is reached, the latency test does not terminate the jackd process. This commit adds `pkill jackd` on test setup to ensure no instance od `jackd` is running. Signed-off-by: Pawel Langowski <pawelx.langowski@intel.com>
PLangowski
force-pushed
the
latency-cleanup-jackd
branch
from
8342ec6 to
38167b7
Compare
KamilxPaszkiet
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes when timeout is reached, the latency test does not terminate the jackd process. This commit adds
pkill jackdon test setup to ensure no instance odjackdis running.